Update 141X data GTs in autoCond #46824
Conversation
|
cms-bot internal usage |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46824/42829 |
|
A new Pull Request was created by @perrotta for master. It involves the following packages:
@atpathak, @cmsbuild, @consuegs, @perrotta can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test TestDQMOnlineClient-scal_dqm_sourceclient had ERRORS Comparison SummarySummary:
|
|
please test with #46742 |
|
abort |
cmsbuild
added
tests-pending
dqm-pending
code-checks-pending
and removed
tests-started
requires-external
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46824/42833
|
|
please test |
|
-1 Failed Tests: UnitTests Unit TestsI found 1 errors in the following unit tests: ---> test TestDQMOnlineClient-scal_dqm_sourceclient had ERRORS Comparison SummarySummary:
|
| @@ -76,7 +76,7 @@ | |||
| process.dqmmodules = cms.Sequence(process.dqmEnv + process.dqmSaver )#+ process.dqmSaverPB) | |||
| process.evfDQMmodulesPath = cms.Path( | |||
| process.l1GtUnpack* | |||
There was a problem hiding this comment.
Hi, just a couple of quick comments:
- from the exception message [1] log here , actually (also)
l1GtUnpackneeds to be changed. - the SCAL FED has been removed from DAQ since the end of Run 2. Do we still need to support this client? The fact that CMSALCAFAST-94 succeeded without these changes is proof that this client is not run anymore in live data-taking.
[1]
----- Begin Fatal Exception 29-Nov-2024 00:46:25 CET-----------------------
An exception of category 'NoRecord' occurred while
[0] Processing Event run: 355380 lumi: 19 event: 26716348 stream: 0
[1] Running path 'evfDQMmodulesPath'
[2] Calling method for module L1GlobalTriggerRawToDigi/'l1GtUnpack'
Exception Message:
No "L1MuTriggerScalesRcd" record found in the EventSetup.
Please add an ESSource or ESProducer that delivers such a record.
----- End Fatal Exception -------------------------------------------------
There was a problem hiding this comment.
Thank you @mmusich
Indeed, removing that test at all would be a much simpler solution: if you also support it, I'll do so. (Now I am traveling, I will do it as soon as I will be able to)
There was a problem hiding this comment.
removing that test at all would be a much simpler solution:
rather than removing the test, I would suggest to remove completely the configuration file of the client.
There was a problem hiding this comment.
Yeah, that would make sense. But I'd let it be done in the proper way by @cms-sw/l1-l2 (or by whoever else wants to do it).
For the sake of just having the updated GTs running without crashes in the CMSSW unit tests system let just comment out here the obsolete one.
There was a problem hiding this comment.
@cms-sw/dqm-l2 can you comment on a possible removal of the client from the release already in this PR?
perrotta
force-pushed
the
updateDataGtInAutocond
branch
from
b0b9c55
to
23b9148
Compare
cmsbuild
added
tests-pending
code-checks-pending
and removed
tests-rejected
code-checks-approved
labels
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-46824/42849 |
|
please test |
|
+1 Size: This PR adds an extra 20KB to repository Comparison SummarySummary:
|
|
+alca
|
Update online GTs in autoCond after the end of the 2024 data taking (to be used for tests and development):
run3_hlt: 141X_dataRun3_HLT_frozen_v2run3_data_express: 141X_dataRun3_Express_frozen_v4run3_data_prompt: 141X_dataRun3_Prompt_frozen_v4Also the offline data GT needed to be fixed:
run3_data: 141X_dataRun3_v5Moreover, to avoid crashes in the unit tests because of the removed (now unused) records in the HLT GT, the commit 6198154 comments out the
scal_dqm_sourceclient-live_cfg.pytest from the ones run in the unit tests of DQM/Integration: as correctly reported in a comment here below, the SCAL FED has been removed from DAQ since the end of Run 2.PR validation:
The removal of the not-needed records from the HLT GT was verified online as documented in CMSALCAFAST-94
Rely on these PR tests for a wider coverage